[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem



Hi Hamish

Excerpts from Hamish D's message of Son Nov 28 23:51:43 +0100 2010:
> OK, here is a set of 4 patches that implement the change over to the
> gpgme library. There's quite a bit of work in there so I thought I'd
> leave it as a few patches, but I have done some tidying.

I just discovered another problem: If the secret key is not available
(because it's on a removable media and the media is not mounted), the
mail is sent anyway. While this is just a bit annoying for signed mail
it definitely should not happen for encrypted mails. Current sup
corectly fails in this case.

It would also be nice to have different colors for different trust
levels. So you don't have to expand the extra information to see if a
valid signature is trusted or not. Is this already possible with the
current hook?

> 
> I have some more ideas for improvements, but I'm happy that this
> reproduces the behaviour of using the gpg binary, and I find sup usage
> much smoother with this change.
> 
> I'll leave it for others to decide whether to stick this in sup 0.12 -
> I guess it could be risky to stick it in without it being tested, but
> maybe it could be applied to the next tree, and then moved to main
> after 0.12 has been released.

As far as I understood the branch layout the flow of changes is master
-> next -> release. So applying to next would mean it ends up in the
next release (0.12).

Gaudenz
-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel