Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem

[Hamish D <dmishd@gmail.com>]

> The "+" character is right in front of the string "Good signature from
> ...". If you move the cursor to that line and press enter it changes
> to a "-" character, but no additional text is shown. The gpg command
> output used to show up there when pressing enter.
>
> I expect there to be some additional output about the signature
> validation like keyid, signature date, trust level, ...

Right, now I know what you are referring to. It is a CryptoNotice
object. That didn't work in the first version of the patch, but I
fixed it in the patch I submitted the second time.

So with the patches submitted in the message with time stamp "8
November 2010 22:32" there will be lines when you expand, telling you
the key ID, the timestamp of the signature and all names and email
addresses associated with that key.

I am also working on having extra information generated when the key
is not trusted, but this is not done yet. And I am also working on a
hook where you can generate as much information as you want from the
signature for the CryptoNotice. Hopefully be ready to submit before
the weekend.

While doing this I'm wondering about the preferred way of submitting
patches that represent quite a bit of work. Should I use git rebase -i
to just have a single patch with all changes, or is it preferred to
have a series of smaller changes?

I also have my code at http://github.com/foobacca/sup - this patch is
being developed in the gpgme branch -
https://github.com/foobacca/sup/tree/gpgme

Hamish
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel