[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Fixed inline gpg crash when the end marker is missing



Excerpts from Michael Hamann's message of Sat Sep 04 23:51:46 +0200 2010:

> lines.between() does not check if the end marker actually exists, but
> later it is assumed the marker exists. This change introduces a check
> for the end marker and doesn't decrypt messages in which the end marker
> is missing. This is a fix for
> http://rubyforge.org/pipermail/sup-talk/2010-August/004209.html

Just encountered this one with some message in the "Error when verifying
tags signed using 1.7.3.1" thread [1] on the git mailing list.
The patch works fine for me, thanks!

FWIW, I think your approach of not trying to decrypt mails that contain
no end marker is the right thing to do: If the end marker is missing,
the message most likely has been garbled in other ways as well (or
simply cut off in the middle), causing decryption to fail anyway.

Sascha

[1] http://marc.info/?t=128623049600001&r=1&w=2
--
http://sascha.silbe.org/
http://www.infra-silbe.de/

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel