[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Fixed inline gpg crash when the end marker is missing

Excerpts from Sascha Silbe's message of Tue Oct 05 07:42:58 -0400 2010:

> Just encountered this one with some message in the "Error when
> verifying tags signed using 1.7.3.1" thread [1] on the git mailing
> list.  The patch works fine for me, thanks!

Yes, me too.  Patch applied and my sup is back in business.

> FWIW, I think your approach of not trying to decrypt mails that
> contain no end marker is the right thing to do: If the end marker is
> missing, the message most likely has been garbled in other ways as
> well (or simply cut off in the middle), causing decryption to fail
> anyway.

I agree with this rationale.  Feeding the entire message to gpg if no
end marker is seen isn't the way to go, I don't think.

Rich, can this hit master?

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel