[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Implement inline GPG (updated)

To: Michael Stapelberg <michael+sup@stapelberg.de>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG (updated)
From: Rich Lane <rlane@club.cc.cmu.edu>
Date: Thu, 11 Mar 2010 23:43:38 -0500
Authentication-results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Cc: sup-devel <sup-devel@rubyforge.org>
Delivered-to: eg@gaute.vetsj.com
Delivered-to: sup-devel@rubyforge.org
In-reply-to: <1268256145-sup-8174@midna.zekjur.net>
List-archive: <http://rubyforge.org/pipermail/sup-devel>
List-help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-id: Sup developer discussion <sup-devel.rubyforge.org>
List-post: <mailto:sup-devel@rubyforge.org>
List-subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>, <mailto:sup-devel-request@rubyforge.org?subject=subscribe>
List-unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>, <mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
References: <1266493070-sup-7733@midna.zekjur.net> <1267219197-sup-2428@zyrg.net> <1267276103-sup-6406@midna.zekjur.net> <1267293663-sup-2241@zyrg.net> <1267450467-sup-4411@midna.zekjur.net> <1267454104-sup-9569@peer.zerties.org> <1267462001-sup-1957@midna.zekjur.net> <1267465546-sup-2321@peer.zerties.org> <1268152912-sup-4673@midna.zekjur.net> <1268256145-sup-8174@midna.zekjur.net>
Reply-to: Sup developer discussion <sup-devel@rubyforge.org>
Sender: sup-devel-bounces@rubyforge.org
User-agent: Sup/git

lib/sup/message.rb:

Since the regexes only match whole lines, why not just do string
comparisons? I'd also like those strings to be constants but I won't
insist on that. 

The body assignment should be a ternary.

I really dislike the flip-flop operator but it looks like the best way
to do this. Please package those selects into a commented Enumerable
method.

Please factor your two cases in message_to_chunks into very well
documented methods. message_to_chunks is already too complicated.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

Follow-Ups:
- Re: [sup-devel] [PATCH] Implement inline GPG (updated)
  - From: Michael Stapelberg <michael+sup@stapelberg.de>

References:
- [sup-devel] [PATCH] Implement inline GPG
  - From: Michael Stapelberg <michael+sup@stapelberg.de>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Rich Lane <rlane@club.cc.cmu.edu>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Michael Stapelberg <michael+sup@stapelberg.de>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Rich Lane <rlane@club.cc.cmu.edu>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Michael Stapelberg <michael+sup@stapelberg.de>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Christian Dietrich <stettberger@dokucode.de>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Michael Stapelberg <michael+sup@stapelberg.de>
- Re: [sup-devel] [PATCH] Implement inline GPG
  - From: Christian Dietrich <stettberger@dokucode.de>
- Re: [sup-devel] [PATCH] Implement inline GPG (updated)
  - From: Michael Stapelberg <michael+sup@stapelberg.de>
- Re: [sup-devel] [PATCH] Implement inline GPG (updated)
  - From: Michael Stapelberg <michael+sup@stapelberg.de>

Prev by Date: Re: [sup-devel] [PATCH] Use multiple body arrays when calling before-edit for each reply type
Next by Date: Re: [sup-devel] [PATCH] Correctly pad date strings, as they might contain utf-8 characters
Previous by thread: Re: [sup-devel] [PATCH] Implement inline GPG (updated)
Next by thread: Re: [sup-devel] [PATCH] Implement inline GPG (updated)
Index(es):
- Date
- Thread