Hi Rich, Excerpts from Rich Lane's message of Fr Mär 12 05:43:38 +0100 2010: > Since the regexes only match whole lines, why not just do string > comparisons? I'd also like those strings to be constants but I won't > insist on that. Good point, I changed that. > The body assignment should be a ternary. I avoided that because the line gets incredibly long then (91 characters vs. 79 characters inside the if. Are you sure you want that ternary? If so, please just change it yourself. > I really dislike the flip-flop operator but it looks like the best way > to do this. Please package those selects into a commented Enumerable > method. Done. > Please factor your two cases in message_to_chunks into very well > documented methods. message_to_chunks is already too complicated. Done. Best regards, Michael
Attachment:
0001-Implement-inline-GPG.patch
Description: Binary data
_______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel