[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Message#edit_labels [was: Ruby question: before-add-message.rb and adding multiple labels at once]



William Morgan, 2010-01-23 15:11:
> This is very similar to ThreadViewMode#multi_edit_labels, so I would
> prefer a solution that shared a codepath.

Similar indeed.  Factored out.

> It's also important to call LabelManager.<< for each label, to make
> sure they appear in label-list-mode.

I went a step further with this.  Counting on people not having
billion-mail threads and gazillions of tags (and thus this potentially
having performance implications) I dropped all the LabelManager.<<
calls to Message to ensure that every time labels change, LabelManager
is informed.

Patch v2 attached.

-- 
Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/

Attachment: 0001-Message-edit_labels.patch
Description: Binary data

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel