[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] XapianIndex.each_message_in_thread_for yields messages in cronological order



Reformatted excerpts from Rich Lane's message of 2009-12-30:
> I'm assuming you're talking about each_message_in_thread_for, since
> that's the only Index method that deals with threading.

Yes, I suppose. In my mind the Xapian index had replaced the ThreadSet
threading entirely, but perhaps that's not the case.

> In what order does ThreadSet#add_message expect to get messages in?

Arbitrary.

> AFAICT JWZ's algorithm should work regardless of the order messages
> handed to it.

That's my understanding too.

I don't like adding date as a component for threading (because it's just
asking for a screwey date to wreak havok, just as a screwey References:
header wreaks havok now). I don't like playing around with the threading
algorithm, not in the least because we don't have a good test harness
that lets us know if we screw something up. So I'm inclined to sit on
this patch.

Out of curiousity, Tero, could the problem also be solved by giving the
in-reply-to header precedence over the references header?
-- 
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel