[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Saved Search Support

Excerpts from Rich Lane's message of Tue Jan 19 13:00:32 -0500 2010:
> I'd like it better if shrinking went away and the only time we expanded
> was right before giving it to parse_query. I'd rather not have the
> expand-on-delete or rename-tracking behaviors.

I'm not sure why I thought any of that was such a great idea.

> I think attempting to expand a nonexistent saved search should result in 
> something false ("type:false", maybe), send a warning to the log, and 
> perhaps flash an error message.

SearchManager#expand now returns false, logs a warning and flashes an error 
message when expansion fails.

> On Ruby 1.9.1 I get:
> lib/sup/search.rb:69: warning: Hash#index is deprecated; use Hash#key

Removed.

> SearchListMode#regen_text: looks like a mixup of each and map

Fixed.

> SearchListMode#add_new_search:
> Should flash an error message on name collisions, or allow overwriting.
>
> SearchListMode#rename_selected_search, SearchListMode#save_search:
> Name collision handling should be consistent with add_new_search.

An error message is flashed.

> SearchManager:
> I'd replace the duplicated name checking regexes with a method.

Replaced.

> SearchManager#rename:
> I think the strip should be done by the caller.

Done.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel