[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCHv2] Saved Search Support

To: Eric Sherman <hyperbolist@gmail.com>
Subject: Re: [sup-devel] [PATCHv2] Saved Search Support
From: Rich Lane <rlane@club.cc.cmu.edu>
Date: Wed, 20 Jan 2010 01:14:46 -0500
Authentication-results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Cc: sup-devel <sup-devel@rubyforge.org>
Delivered-to: eg@gaute.vetsj.com
Delivered-to: sup-devel@rubyforge.org
In-reply-to: <1263959248-sup-4163@changeling.local>
List-archive: <http://rubyforge.org/pipermail/sup-devel>
List-help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-id: Sup developer discussion <sup-devel.rubyforge.org>
List-post: <mailto:sup-devel@rubyforge.org>
List-subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>, <mailto:sup-devel-request@rubyforge.org?subject=subscribe>
List-unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>, <mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
References: <1263858172-sup-547@changeling.local> <1263920054-sup-9400@zyrg.net> <1263959248-sup-4163@changeling.local>
Reply-to: Sup developer discussion <sup-devel@rubyforge.org>
Sender: sup-devel-bounces@rubyforge.org
User-agent: Sup/git

Excerpts from Eric Sherman's message of 2010-01-19 22:48:50 -0500:
> There is no nesting limit and searches are always expanded completely
> before they are turned into proper queries for the index.

What do you think about doing the expansion in Index.parse_query, right
after the custom-search hook? That would save you from keeping track of
the unexpanded text. Otherwise this patch looks good to me.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

Follow-Ups:
- Re: [sup-devel] [PATCHv2] Saved Search Support
  - From: Eric Sherman <hyperbolist@gmail.com>
- Re: [sup-devel] [PATCHv3] Saved Search Support
  - From: Eric Sherman <hyperbolist@gmail.com>

References:
- [sup-devel] [PATCH] Saved Search Support
  - From: Eric Sherman <hyperbolist@gmail.com>
- Re: [sup-devel] [PATCH] Saved Search Support
  - From: Rich Lane <rlane@club.cc.cmu.edu>
- Re: [sup-devel] [PATCHv2] Saved Search Support
  - From: Eric Sherman <hyperbolist@gmail.com>

Prev by Date: Re: [sup-devel] [PATCHv2] Saved Search Support
Next by Date: [sup-devel] Problems Syncing
Previous by thread: Re: [sup-devel] [PATCHv2] Saved Search Support
Next by thread: Re: [sup-devel] [PATCHv2] Saved Search Support
Index(es):
- Date
- Thread