[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [sup-devel] [PATCH] Return nothing between if end index is not found.
Excerpts from Michael Stapelberg's message of Tue Aug 17 18:46:32 -0400 2010:
> Interesting. I gzipped it (to make sure it does not get touched in any way on
> its way to you) and attached it to this mail.
I finally got around to looking at your message, and as expected, it appears
that there is no trailing END PGP MESSAGE block, which is why my patch breaks
your behavior (it claims there is no valid PGP block.)
Regardless of what the PGP standard says, I suppose it's good practice
to be liberal in what we accept. So the correct change might be to
keep the existing semantics of between (documenting carefully what happens
if the ending line is not present) and then fixing the code that relies
on the bogus invariant.
This also resolves Kevin Riggle’s issue.
Cheers,
Edward
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel