[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] Adding backward synchronization for Maildir sources



Sup Edward,

Thank you for your feedback!

Excerpts from Edward Z. Yang's message of Mon Jul 19 00:46:33 +0200 2010:
> It makes Sup very crashy and there's some strange behavior.  This is probably
> the sixth time I'm composing this message (yeah, haven't learned my
> lesson.) In more detail...

I'm impressed, I never experienced such crashes, it is quite stable
here but I use only very basic hooks.

> * Backwards syncing appears to make old deleted mail show up again; I'm not
>   sure if it's because touching the Maildir causes Sup to pick up on deleted
>   tags again or something, but I had to go back and delete lots of deleted mail.

Hmm, strange, do you use the latest commits of the branch? I pushed a
fix for deleted mails about 10 days ago.

The mails that show up again don't have the deleted flag at all?

> * When Sup is deleting messages, it is /extremely/ unsafe to iterate over
>   a list of all messages in the index and query them for info: the threading means
>   that any given message might not exist anymore.  I had a hook that kept triggering
>   this bug, and earlier on in the process drawing functions would also frequently
>   Nil error.  This is probably under-tested codepaths in Sup that we should track
>   down; unfortunately I didn't have the presence of mind to record traces until
>   later (and the ones I got all look like my hooks fault).

I did not test the code with hooks, what do you suggest for this one?

> * In a similar vein, while messages are going away, '@' will occasionally return
>   no messages (pressing again usually fixes it).  Messages that are labelled inbox
>   will show up in 'U', but not in the inbox view without a Sup restart.

I never use this keybinding but indeed I noticed that pressing '@' two
times in a row was not showing anything.

I will try to track down these bugs.

Thanks again!
Cheers,

--
Damien Leone <damien.leone@fensalir.fr>

Web: http://dleone.fensalir.fr/
GPG: 0x82EB4DDF

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel