Re: [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode

[Rich Lane <rlane@club.cc.cmu.edu>]

Excerpts from Michael Stapelberg's message of 2010-02-27 07:48:39 -0500:
> Hi Rich,
> 
> Excerpts from Rich Lane's message of Sa Feb 27 09:23:39 +0100 2010:
> > What's the reason for passing the BufferManager singleton as an
> > argument?
> I am passing the BufferManager because I could not figure out how to access
> it from inside the Ncurses module. Maybe there is a better way, if so, please
> tell me :-).

The reason we use these ugly singleton *Manager objects is to avoid
exactly this kind of plumbing. Since Ncurses is outside the Redwood
namespace you'll need to refer to it as Redwood::BufferManager.

> > What does "drop the input" mean?
> It means returning nil instead of Ncurses.getch, so maybe a better way of
> saying it is "We do not check for input because it would restart Ncurses
> while in shell-out mode".

Ok, that's how I read the code. When I saw "drop" in the comment I
thought it was going to read input and throw it away.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel