Excerpts from Damien Leone's message of Sun Mar 13 17:13:05 +0100 2011: > Sup guys, > > Please see commit messages for detailed informations. > Attachment: 0001-reply-mode-improve-the-way-headers-are-handled.patch This one would possibly break my workflow. My From address is chosen in the before-edit hook based on the set of recipients. Since you only call before-edit once with headers_full as headers, whatever From address gets chosen for the initial reply mode will "stick". It also seems that something I wanted to do for some time was already possible with the old code, but isn't anymore with yours: Changing the contents of the To and CC fields for the selector. Even arbitrary headers (Mail-Followup-To in my case) could be keyed on the selector. I now understand why before-edit was invoked multiple times. :) And the part where I need to avoid modifying the body on subsequent invocations looks like a bug in the original code: @bodies[k] should contain a _copy_ of body (currently all @bodies[k] contain a reference to the same instance, rendering the Hash useless). BTW, do you know about Hash.merge! ? Some parts of your code could have been simplified by using merge! instead of merge. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel