[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH] Delete messages from index if there is no location left

Excerpts from Sascha Silbe's message of ven fév 11 15:30:15 +0100 2011:
> If messages don't have any location, we cannot access their body and are also
> unable to restore them from a message state dump (written by sup-dump). So
> it's more consistent to the user if we remove them completely. This is
> most likely what the user expects anyway: why else would they delete the
> message from all locations?

Yes, I agree with you, this should be the normal behaviour.

> I've had this in my branch for quite some time now, but didn't have a
> a chance yet to thoroughly test it after rebasing on top of next (which
> made changes in the same area of the code, causing conflicts). Feel
> free to push to next and/or master once you verified it doesn't cause
> you to loose mails.
> 
>  bin/sup-sync     |    9 +++++++++
>  lib/sup/index.rb |    9 +++++++++
>  lib/sup/poll.rb  |    9 +++++++++
>  3 files changed, 27 insertions(+), 0 deletions(-)
> [...]

Thanks for this patch !
I going to try to merge it with my current Sup version.
-- 
Romain Dessort
Jabber ID : romain@univers-libre.net
GnuPG : 3072D/724BC532
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel