[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-talk] [PATCH] moved deriving the cmd for bouncing to Account and fixed a bug in it



Excerpts from Tero Tilus's message of Sat Oct 10 03:21:33 -0400 2009:
> The default sendmail command used for bouncing mail was derived from
> Account#sendmail in ThreadViewMode#bounce.  Moved it to
> Account#bounce_sendmail.  Part of work towards more DRY mail bouncing
> within mark-as-spam hook. The code also had a bug, "$1" (instead of $1
> or "#{$1}").  Fixed it.
> 
> Signed-off-by: Tero Tilus <tero@tilus.net>
> ---
>  lib/sup/account.rb                |   11 +++++++++++
>  lib/sup/modes/thread-view-mode.rb |    7 +------
>  2 files changed, 12 insertions(+), 6 deletions(-)

Looks good to me. Pushed to branch fix-bounce-cmd in my repo* and merged
to master.

* git://github.com/rlane/sup
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk