[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-talk] [PATCH] detect and set charset on text/* attachments



Excerpts from William Morgan's message of Tue Nov 03 18:16:32 +0100 2009:
> It looks like the chardet gem is unmaintained. But someone decided to
> make their own special version called rchardet which is completely
> equivalent version but *is* maintained. 
> 
> I suggest we use rchardet instead of chardet. Would you like to change
> the patch? If not, I will get to it at some point.

Here you go!

One thing I noticed when trying it out: It will set charset 'ascii' for ascii
text, which is allowed by the RFC but "US-ASCII" is preferred. I think I prefer
to not create a special case in the code to change it to US-ASCII or remove the
charset for ascii text, but other people might disagree.
-- 
alge

Attachment: 0001-Detect-charset-for-text-file-attachments.patch
Description: Binary data

_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk