[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-talk] Problems with undo archive and thread focus



Excerpts from Andrew Pimlott's message of Thu Nov 12 12:30:01 -0500 2009:
> Excerpts from Matthias Guedemann's message of Thu Nov 05 00:27:25 -0800 2009:
> > One is, if you hit 'a' in thread view mode, the thread is archived but undo does
> > not work. If you go back to index view and hit 'u' the just archived thread does
> > not appear, but the one before.
> 
> I was annoyed by this too and found that undo is minimally implemented.
> I added undo to thread view, at least for the cases that I care about or
> were easy.  I have to say I was discouraged that this was necessary: the
> code to archive a thread should all be in one place, and the undo
> record should be created there.  There's a lot of code duplication, and
> I can't tell if it's because the model and view are too coupled, or
> because nobody has bothered to factor it out.
> 
> The patch is appended.  (This is the first time I've done this with git.)

Branch thread-view-mode-undo, merged to master at
git://github.com/rlane/sup
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk