[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-talk] Maildir sent_source

On Tue, Dec 21, 2010 at 12:56:23PM +0200, Tero Tilus wrote:
> I do see it.  ;)

Yeah, me too now :-).

> Judging by the code it looks like you also need to sup-add your
> maildir in addition to adding it to config.  If
> Redwood::SourceManager.source_for doesn't find the source it silently
> drops back to default sent source.  IMO it should complain about
> invalid config or something.

I agree, this inconsistency should not go through without flagging it
and terminating with an error.

Alternatively, the patch below would allow for adding a maildir source
before the default logic kicks in.

   Matthias

--- a/bin/sup
+++ b/bin/sup
@@ -158,6 +158,9 @@ begin
   trap("TERM") { |x| $die = true }
   trap("WINCH") { |x| BufferManager.sigwinch_happened! }
 
+  HookManager.run "startup"
+  Redwood::Keymap.run_hook global_keymap
+
   if(s = Redwood::SourceManager.source_for DraftManager.source_name)
     DraftManager.source = s
   else
@@ -171,9 +174,6 @@ begin
     Redwood::SourceManager.add_source SentManager.default_source
   end
 
-  HookManager.run "startup"
-  Redwood::Keymap.run_hook global_keymap
-
   debug "starting curses"
   Redwood::Logger.remove_sink $stderr
   start_cursing

_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk