[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-talk] sup leaves unencrypted emails in /tmp



Excerpts from Hamish D's message of Wed Dec 01 17:18:08 -0700 2010:
> I noticed that sup appears to leave the unencrypted contents of emails
> in /tmp - at least it did on my system. This is a pretty serious issue
> on shared computers. I'm not sure why - my attempts at a quick fix
> failed. The files are created using Tempfile.new and close is called,
> but after that the files are written to by gpg. I'm not sure if this
> means that the tempfile system then doesn't delete them later for some
> reason.

Tempfile is interesting because the file is not deleted until the object
is garbage-collected.  From the Tempfile.close rdoc:

     If you don't explicitly unlink the temporary file, the removal will
     be delayed until the object is finalized.

So if I'm understanding this correctly, the tempfiles may or may not be
cleaned up, depending on when the garbage collector runs (e.g., if the
GC runs before gpg is run, the original tempfile will have already been
deleted, and the new file created by gpg will live on indefinitely).

I was going to write a patch, but I don't do anything use gpg often so
it wasn't convenient to test.  I think an easy solution would just be to
add a 'File.unlink whatever.path' call after each call to gpg (this
would need to be done in encrypt/decrypt/sign/etc.).

Cam
_______________________________________________
sup-talk mailing list
sup-talk@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk