[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH 01/10] open mail source files as binary



Excerpts from Rich Lane's message of Thu Dec 31 16:36:49 -0700 2009:
> diff --git a/lib/sup/maildir.rb b/lib/sup/maildir.rb
> index c2bd27a..0852576 100644
> --- a/lib/sup/maildir.rb
> +++ b/lib/sup/maildir.rb
> @@ -59,7 +59,7 @@ class Maildir < Source
>          File.stat(tmp_path)
>        rescue Errno::ENOENT #this is what we want.
>          begin
> -          File.open(tmp_path, 'w') do |f|
> +          File.open(tmp_path, 'wb:BINARY') do |f|
>              yield f #provide a writable interface for the caller

This patch causes the following warning on Ruby 1.8:
warning: encoding options not supported in 1.8: wb:BINARY

Especially if you use Maildir for a source, the resulting torrent of warnings
makes Sup a bit difficult to use.

I've gone and reverted this diff locally for now. I suppose I could also stop
running sup with the -w flag...
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel