[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCH 2/2] {config, sources}.yaml: preserve symlinks and permissions



Excerpts from William Morgan's message of Wed Jan 19 16:38:11 +0100 2011:

> Reformatted excerpts from Sascha Silbe's message of 2011-01-18:
> > +      unless File.exists?(backup_fn) && File.size(fn) == 0
> 
> This line is giving me some problems when fn doesn't exist (e.g. when
> running sup-sync the first time without a config.yaml). Should it be
> 
>   File.exists?(backup_fn) && File.exists?(fn) && File.size(fn) == 0
> 
> instead?

Yes, you're right. We shouldn't try to do a copy if the original doesn't
exist. Sorry for not testing that case.
Shall I send a fix-up patch?

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel