[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[sup-devel] [PATCH] Fix signing of multipart messages



Hi

Sup currently crashes when you try to sign a multipart message. This
is fixed by the first patch.

Additionally the signatures created for multipart messages are wrong,
because the incorrect MIME-Version header is stripped before signing
but not when actually constructing the message.

RMail automagically adds these MIME-Version headers on serialization.
This also creates problems on signature verification of signed
multipart messages. 

The second patch addresses these two problems by monkey patching RMail
to no longer automagically add MIME-Version headers. This is not
really elegant, but I could not come up with a better way to avoid the
various side effects on signatures of automatically messing with mail
parts on serialization.

For the monkey patch to be applied the require statements had to be
rearranged so that rmail is included before sup/util.

If someone knows a better fix than monkey patching I would be more
than happy...

Gaudenz

P.S.: Do you rather prefer patches as attachments or inline patches?
--
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

Attachment: 0001-Encode-multipart-messages-for-crypt-operations.patch
Description: Binary data

Attachment: 0002-Monkey-patch-RMails-MIME-Version-header-handling.patch
Description: Binary data

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel