[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] Patch: Always try to canonize person name using ContactManager



Excerpts from Tero Tilus's message of lun ene 24 20:33:23 -0300 2011:
> Sup has mostly not been using the names defined in contacts.txt when
> displaying messages.  I vaguely remember seeing an issue reported on
> something similar to this.  I became annoyed enough and fixed it.
> 
> Now Person.from_address first tries to find the person using
> ContactManager (if it is instantiated) and falls back to
> Person.new(name, email).

I tried this patch -- works great, thanks.

One minor nit, probably material for another patch: the list of names
that's built in the thread index mode doesn't seem to use this
facility, and so when you have a thread that includes several emails
from the same account but inconsistent names, that person is listed more
than once in the "participants" column, with the different names.

(For example I have a thread from Fabian, Fabián, and fabian.martinez
that all come from the same fabian.martinez@example.com account).

-- 
Álvaro Herrera -- Se vende casa en Ñuñoa: www.portalinmobiliario.com/993147
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel