[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [sup-devel] [PATCHES] Add an account selector in edit-mode
Hello,
Sorry I have been quite busy finishing my degree last weeks. I planned
to review and answer but it got delayed and delayed.
Thanks for pushing and fixing the issue with alternate addresses. I
will fetch it and let you know.
Excerpts from Hamish's message of dim. juin 19 23:48:40 +0200 2011:
> Excerpts from Hamish's message of Mon May 30 18:23:10 +0100 2011:
> > Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011:
> > > 0002-edit-message-mode-Add-an-optional-account-selector.patch
> >
> > I imagine though that you would want to handle all the possible email
> > addresses, so I've written an extra patch to do that, and pushed your
> > patch and mine onto the (new) account_selector branch on gitorious.
> > Please have a look and see if what I've done still works for you, and is
> > what you meant.
> >
> > I also wondered whether to change the behaviour so that the account
> > selector will only appear if there is more than one possible email
> > address to choose from, but I thought it would be handy to be able to
> > reset the From: header to your usual From: using the selector, rather
> > than having to hand edit whatever was in the To: header that you are
> > replying to. What do you think?
> >
> > I'll wait for you to review my changes before I merge this into next.
> > (My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1)
>
> I've not heard anything for a bit, so I've pushed this into next for
> wider testing, with the guard so that the account selector will only
> appear if you have more than one email address. Shout out if it causes
> any problems.
>
> Hamish
--
Damien Leone <damien.leone@fensalir.fr>
GPG: 0x82EB4DDF
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel