[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sup-devel] [PATCHES] Add an account selector in edit-mode



Excerpts from Sascha Silbe's message of Mon Jun 20 14:47:57 +0100 2011:
> This breaks the "Reply to" selector for me. Any attempt to change the
> value results in an exception:
> 
> So account_selector.selection is nil. The only way for that to happen is
> by calling account_selector.set_to() with a value that's not in
> account_selector.vals (IMO HorizontalSelector should throw an exception
> in that case, BTW). Any idea where and why that would have happened?

I'm afraid I couldn't reproduce your exception - do you have several
accounts? Multiple email addresses per account?

Anyway I've pushed an update to the account_selector branch (commit
5bb55890) that you could try out. The basic change is that in the
original patch, there was:

    @account_selector =
      HorizontalSelector.new "Account:", AccountManager.user_accounts + [nil], user_emails_copy + ["Customized"]

Note the [nil] added to the end of the first array. I've changed that to
[:user] (in line with the replyto selector) and made the other changes
in the file to stay in line with that. As I say I can't reproduce your
problem, so I'm not 100% sure I've solved it, so let me know how you get
on. If it fixes it for you I'll put the patch onto next aswell.

Hamish Downer
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel